[6.0] Adds missing use statements to VersionableModelTrait.php. #46063#46064
Closed
lemuelvdm wants to merge 1 commit intojoomla:6.0-devfrom
Closed
[6.0] Adds missing use statements to VersionableModelTrait.php. #46063#46064lemuelvdm wants to merge 1 commit intojoomla:6.0-devfrom
lemuelvdm wants to merge 1 commit intojoomla:6.0-devfrom
Conversation
tecpromotion
changed the title
Member
|
Possibly the issue is caused by PR #45515 ? In this case wait with this PR as we maintainers have decided to revert that PR, which will happen soon. |
Contributor
|
should never have been merged as I repeatedly said at the time |
Member
|
See PR #46065 . It's work in progress, I will finish it tomorrow. |
Member
|
@lemuelvdm Thanks for your contribution. However, we have another PR #46073 which will fix the issue. Closing in favour of that PR. Sorry and thanks for your understanding. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #46063.
Summary of Changes
Adds the missing use statements to VersionableModelTrait.php
Testing Instructions
Restore a old version of view or field in J6.
Actual result BEFORE applying this Pull Request
When trying to restore old version f the following error is returned:
Class "Joomla\CMS\Versioning\ContentHistory" not foundExpected result AFTER applying this Pull Request
The prior version is restored sucessfully
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed